Skip to content

Commit

Permalink
Fix tests, add contributors
Browse files Browse the repository at this point in the history
  • Loading branch information
timokoessler committed Jan 12, 2025
1 parent cf335cd commit d304961
Show file tree
Hide file tree
Showing 5 changed files with 145 additions and 1 deletion.
97 changes: 97 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
{
"projectName": "2FAGuard",
"projectOwner": "timokoessler",
"repoType": "github",
"repoHost": "https://github.com",
"files": [
"CONTRIBUTORS.md"
],
"imageSize": 100,
"commit": false,
"commitConvention": "none",
"contributors": [
{
"login": "timokoessler",
"name": "Timo Kössler",
"avatar_url": "https://avatars.githubusercontent.com/u/33259218?v=4",
"profile": "https://github.com/timokoessler",
"contributions": [
"code",
"maintenance",
"review",
"design",
"translation"
]
},
{
"login": "Cristian9828",
"name": "Cristian9828",
"avatar_url": "https://avatars.githubusercontent.com/u/51407503?v=4",
"profile": "https://github.com/Cristian9828",
"contributions": [
"translation",
"bug"
]
},
{
"login": "reg-chen",
"name": "Reg Chen",
"avatar_url": "https://avatars.githubusercontent.com/u/34430957?v=4",
"profile": "https://github.com/reg-chen",
"contributions": [
"translation",
"bug"
]
},
{
"login": "epver",
"name": "Epver",
"avatar_url": "https://avatars.githubusercontent.com/u/8299627?v=4",
"profile": "https://github.com/epver",
"contributions": [
"translation"
]
},
{
"login": "leftertrp",
"name": "Lefteris T.",
"avatar_url": "https://crowdin-static.downloads.crowdin.com/avatar/15330686/large/4230178a6a5663e2704f0822c60cb74c_default.png",
"profile": "https://crowdin.com/profile/leftertrp",
"contributions": [
"translation"
]
},
{
"login": "jdunham22",
"name": "Jason Dunham",
"avatar_url": "https://avatars.githubusercontent.com/u/723070?v=4",
"profile": "https://github.com/jdunham22",
"contributions": [
"bug",
"ideas"
]
},
{
"login": "PascalReintjensDSGF",
"name": "PascalReintjensDSGF",
"avatar_url": "https://avatars.githubusercontent.com/u/186927574?v=4",
"profile": "https://github.com/PascalReintjensDSGF",
"contributions": [
"ideas",
"bug"
]
},
{
"login": "ThatGuyJon",
"name": "ThatGuyJon",
"avatar_url": "https://avatars.githubusercontent.com/u/54686106?v=4",
"profile": "https://github.com/ThatGuyJon",
"contributions": [
"ideas",
"bug"
]
}
],
"contributorsPerLine": 6,
"linkToUsage": false
}
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Contributing

Any contribution is greatly appreciated 🥳. You don't need to be a developer to contribute. You can help by translating the app, reporting issues, or simply sharing your ideas for new features.
All contributors are listed in [CONTRIBUTORS.md](CONTRIBUTORS.md).

If you have any questions, please do not hesitate to contact me. You can find my contact information in the README and on my website.

Expand Down
30 changes: 30 additions & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
## Contributors ✨

Thanks to all the people who have already contributed to 2FAGuard ([emoji key](https://allcontributors.org/docs/en/emoji-key)):

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore-start -->
<!-- markdownlint-disable -->
<table>
<tbody>
<tr>
<td align="center" valign="top" width="16.66%"><a href="https://github.com/timokoessler"><img src="https://avatars.githubusercontent.com/u/33259218?v=4?s=100" width="100px;" alt="Timo Kössler"/><br /><sub><b>Timo Kössler</b></sub></a><br /><a href="https://github.com/timokoessler/2FAGuard/commits?author=timokoessler" title="Code">💻</a> <a href="#maintenance-timokoessler" title="Maintenance">🚧</a> <a href="https://github.com/timokoessler/2FAGuard/pulls?q=is%3Apr+reviewed-by%3Atimokoessler" title="Reviewed Pull Requests">👀</a> <a href="#design-timokoessler" title="Design">🎨</a> <a href="#translation-timokoessler" title="Translation">🌍</a></td>
<td align="center" valign="top" width="16.66%"><a href="https://github.com/Cristian9828"><img src="https://avatars.githubusercontent.com/u/51407503?v=4?s=100" width="100px;" alt="Cristian9828"/><br /><sub><b>Cristian9828</b></sub></a><br /><a href="#translation-Cristian9828" title="Translation">🌍</a> <a href="https://github.com/timokoessler/2FAGuard/issues?q=author%3ACristian9828" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="16.66%"><a href="https://github.com/reg-chen"><img src="https://avatars.githubusercontent.com/u/34430957?v=4?s=100" width="100px;" alt="Reg Chen"/><br /><sub><b>Reg Chen</b></sub></a><br /><a href="#translation-reg-chen" title="Translation">🌍</a> <a href="https://github.com/timokoessler/2FAGuard/issues?q=author%3Areg-chen" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="16.66%"><a href="https://github.com/epver"><img src="https://avatars.githubusercontent.com/u/8299627?v=4?s=100" width="100px;" alt="Epver"/><br /><sub><b>Epver</b></sub></a><br /><a href="#translation-epver" title="Translation">🌍</a></td>
<td align="center" valign="top" width="16.66%"><a href="https://crowdin.com/profile/leftertrp"><img src="https://crowdin-static.downloads.crowdin.com/avatar/15330686/large/4230178a6a5663e2704f0822c60cb74c_default.png?s=100" width="100px;" alt="Lefteris T."/><br /><sub><b>Lefteris T.</b></sub></a><br /><a href="#translation-leftertrp" title="Translation">🌍</a></td>
<td align="center" valign="top" width="16.66%"><a href="https://github.com/jdunham22"><img src="https://avatars.githubusercontent.com/u/723070?v=4?s=100" width="100px;" alt="Jason Dunham"/><br /><sub><b>Jason Dunham</b></sub></a><br /><a href="https://github.com/timokoessler/2FAGuard/issues?q=author%3Ajdunham22" title="Bug reports">🐛</a> <a href="#ideas-jdunham22" title="Ideas, Planning, & Feedback">🤔</a></td>
</tr>
<tr>
<td align="center" valign="top" width="16.66%"><a href="https://github.com/PascalReintjensDSGF"><img src="https://avatars.githubusercontent.com/u/186927574?v=4?s=100" width="100px;" alt="PascalReintjensDSGF"/><br /><sub><b>PascalReintjensDSGF</b></sub></a><br /><a href="#ideas-PascalReintjensDSGF" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/timokoessler/2FAGuard/issues?q=author%3APascalReintjensDSGF" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="16.66%"><a href="https://github.com/ThatGuyJon"><img src="https://avatars.githubusercontent.com/u/54686106?v=4?s=100" width="100px;" alt="ThatGuyJon"/><br /><sub><b>ThatGuyJon</b></sub></a><br /><a href="#ideas-ThatGuyJon" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/timokoessler/2FAGuard/issues?q=author%3AThatGuyJon" title="Bug reports">🐛</a></td>
</tr>
</tbody>
</table>

<!-- markdownlint-restore -->
<!-- prettier-ignore-end -->

<!-- ALL-CONTRIBUTORS-LIST:END -->

Any kind of contribution is welcome! 🎉 This list includes everyone who has contributed code or translations or created multiple valid bug reports/feature requests.
16 changes: 16 additions & 0 deletions Guard.Test/Core/Translations.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ public void CheckKeys()
foreach (XElement element in resource.Root.Elements())
{
Assert.NotNull(element);
if (element.Name.LocalName == "Style")
{
continue;
}
Assert.Equal("String", element.Name.LocalName);
string key = GetXKey(element);
Assert.StartsWith("i.", key);
Expand All @@ -56,6 +60,10 @@ public void CheckValues()
foreach (XElement element in resource.Root.Elements())
{
Assert.NotNull(element);
if (element.Name.LocalName == "Style")
{
continue;
}
Assert.Equal("String", element.Name.LocalName);
string? value = element.Value;
Assert.NotNull(value);
Expand All @@ -75,6 +83,10 @@ public void CheckDuplicates()
foreach (XElement element in resource.Root.Elements())
{
Assert.NotNull(element);
if (element.Name.LocalName == "Style")
{
continue;
}
Assert.Equal("String", element.Name.LocalName);
string key = GetXKey(element);
Assert.DoesNotContain(key, keys);
Expand All @@ -95,6 +107,10 @@ public void CheckConsistency()
foreach (XElement element in resource.Root.Elements())
{
Assert.NotNull(element);
if (element.Name.LocalName == "Style")
{
continue;
}
Assert.Equal("String", element.Name.LocalName);

if (!first)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ If you lost your password and cannot use an additional login method like Windows

## Contributing

Any contribution is greatly appreciated 🥳. Please take a look at [Contributing](https://github.com/timokoessler/2FAGuard/blob/main/CONTRIBUTING.md) for more information.
Any contribution is greatly appreciated 🥳. Please take a look at [Contributing](https://github.com/timokoessler/2FAGuard/blob/main/CONTRIBUTING.md) for more information. Thanks to all existing [contributors](CONTRIBUTORS.md).

## Contact

Expand Down

0 comments on commit d304961

Please sign in to comment.