Repository navigation
runtime: add weak.Pointer.Value compatibility shim - #5714
Merged
Merged
Conversation
Member
Author
|
Ah, there is already #5698, but it adds a test that shouldn't be required (other tests in the repo can catch this), and did not correctly cross ref the issue for closing, so I did not notice. |
TinyGo currently keeps the original pointer strongly reachable when a weak pointer is registered. Add the matching conversion hook so weak.Pointer.Value links while retaining the existing no-op semantics.
jakebailey
force-pushed
the
runtime-weak-pointer
branch
from
September 20, 2026 23:38
3c38ed1 to
a3c504b
Compare
deadprogram
approved these changes
Sep 22, 2026
deadprogram
left a comment
deadprogram
left a comment
Member
There was a problem hiding this comment.
A few minor nits, but probably not worth mentioning. Thank you @jakebailey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows more of the reflect package to work. (Part of a big stack I'm working on)
The reverse of
registerWeakPointer.Probably full weak pointer support is possible with some GCs but that's out of scope for this fix.
Fixes #5693