Repository navigation
syscall: report unsupported WASI chown/fchown/lchown - #5867
Open
jakebailey wants to merge 1 commit into
Open
jakebailey wants to merge 1 commit into
jakebailey wants to merge 1 commit into
Conversation
WASI does not expose file ownership changes. Calling missing libc symbols leaves unresolved imports and can prevent a whole program from starting. Return ENOSYS as Go does instead of requiring host ownership functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WASI can't do these, but trying to defer them to libc anyway broke the build when used instead of just doing ENOSYS like upstream Go. Fix that.
I don't know anything about the Nintendo DS, so, I just copied the old code for it 😄