WASM GC backend #355
Open
WASM GC backend #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to weird setting by people like me
Should be a plain merge ...
Should be an ordinary merge
titzer
reviewed
Feb 26, 2025
aeneas/src/wasm/WasmCommon.v3
Outdated
| @@ -0,0 +1,230 @@ | |||
| // Copyright 2016 Google Inc. All rights reserved. | |||
There was a problem hiding this comment.
Changed to add: Eliot Moss 2024-2025. If I should be using something different, let me know ...
aeneas/src/ir/Ir.v3
Outdated
| @@ -40,6 +41,7 @@ class IrClass extends IrItem { | |||
| } | |||
| return m; | |||
| } | |||
| def accept<E, R>(v: IrVisitor<E, R>, env: E) -> R { return v.visitIrClass(this, env); } | |||
There was a problem hiding this comment.
I think I'd prefer not introducing visitors for this; a match on the type is locally more compact and usually keeps the logic in one place.
| _ => return this.tag; | ||
| } | ||
| } | ||
| def equals(other: WasmValueType) -> bool { |
There was a problem hiding this comment.
IIUC there shouldn't be a need for an equals method; variants get a == that is a deep structural comparison. As long as every case is OK with that (looking at the RefNull case).
There was a problem hiding this comment.
The RefNull case requires equality on WasmHeapTypes, and they are classes, not ADTs. So I left this for now.
… wasm_gc_backend_PR Should be an ordinary merge of upstream changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix batch of changes being submitted for comment. Work ends essentially just after the point where mtables are processed to obtain function table information.