WIP attempt to get serial and RS485 Modbus-RTU working#35
Conversation
|
Hello @iconnor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-08-16 03:56:14 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 95.83% 96.03% +0.19%
==========================================
Files 6 6
Lines 841 857 +16
==========================================
+ Hits 806 823 +17
+ Misses 35 34 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Still WIP: I am waiting for Acrel to give me the registry map, but if I get an ABB one first, I will post it in the PR |
|
I have the manual but the values are not changing despite energy flow: https://swordandstone-my.sharepoint.com/:b:/g/personal/ianconnor_swordandstone_com_au/ETclJIj1jX1GreQjrtyl88YBzintfvcHlodOC6UyEoOODg?e=eFKsUB so still have some work on this one. |
Testing on a Acrel acr10r-d16te but it is not working yet so please don't merge.