Examples: fix identifier reuse parse failures#251
Open
ahelwer wants to merge 1 commit intotlaplus:mainfrom
Open
Examples: fix identifier reuse parse failures#251ahelwer wants to merge 1 commit intotlaplus:mainfrom
ahelwer wants to merge 1 commit intotlaplus:mainfrom
Conversation
ahelwer
force-pushed
the
example-parse-errors
branch
from
64c6a4e to
eecf2c5
Compare
Several specs in the examples subdirectory fail to parse when checked with SANY, due to reusing identifier names already defined in an enclosing scope. TLAPM accepted these specs but SANY does not, as TLA+ does not allow definition shadowing. Also disable a test in the examples directory which was failing because it required importing the community modules. Signed-off-by: Andrew Helwer <ahelwer@pm.me>
ahelwer
force-pushed
the
example-parse-errors
branch
from
eecf2c5 to
7c2a046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several specs in the examples subdirectory fail to parse when checked with SANY, due to reusing identifier names already defined in an enclosing scope. TLAPM accepted these specs but SANY does not, as TLA+ does not allow definition shadowing.
Ref #136