Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for matching tags using regular expressions #22

Closed
wants to merge 1 commit into from

Conversation

esb
Copy link

@esb esb commented Jun 23, 2018

No description provided.

@skatkov
Copy link
Collaborator

skatkov commented Jul 17, 2018

You changes has caused test to fail. I would appreciate if you could fix them.

Can you please provide a bit more information about the change? Do you have a use case for it? I was considering similar functionality, but couldn't find a usecase that would justify it.

@skatkov
Copy link
Collaborator

skatkov commented Jul 17, 2018

Oh, noticed that you already explained your use case in #11 issue. If you will get testsuit to green, I'd be happy to release it.

@cattekin
Copy link
Contributor

cattekin commented Oct 4, 2019

@skatkov this PR would probably pass checks if it was rebased off master

@skatkov
Copy link
Collaborator

skatkov commented Oct 6, 2019

@cattekin

Thanks for nudging. I've noticed that author of this pull request actually provided valid use case for this code.

I'll try to come back to this PR later.(swapped with things right now) If anyone is keen to rebase this (or create a separate PR) -- i'll be happy to merge.

@skatkov
Copy link
Collaborator

skatkov commented Jan 2, 2021

Closing due to lack of activity

@skatkov skatkov closed this Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants