-
Notifications
You must be signed in to change notification settings - Fork 109
Docstring updates, bolster linting #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31fd940
to
9f1ab61
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 88.66% 88.67%
=======================================
Files 35 35
Lines 3521 3522 +1
Branches 488 488
=======================================
+ Hits 3122 3123 +1
Misses 288 288
Partials 111 111 ☔ View full report in Codecov by Sentry. |
e7ddf82
to
af50745
Compare
224277f
to
08da8bc
Compare
docs/conf.py:57:1: A001 Variable `copyright` is shadowing a Python builtin src/libtmux/common.py:142:9: A001 Variable `vars` is shadowing a Python builtin src/libtmux/common.py:179:9: A001 Variable `vars` is shadowing a Python builtin src/libtmux/server.py:618:25: A002 Argument `id` is shadowing a Python builtin src/libtmux/session.py:621:25: A002 Argument `id` is shadowing a Python builtin src/libtmux/window.py:656:25: A002 Argument `id` is shadowing a Python builtin
src/libtmux/common.py:423:17: EM103 Exception must not use a `.format()` string directly, assign to variable first
08da8bc
to
4269d8a
Compare
4269d8a
to
0c7db83
Compare
tony
added a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
docstring fixes
Server, Session, Window, Pane, and common docstring fixes
ruff linting
flake8-commas (COM)
flake8-builtins (A)
flake8-errmsg (EM)