Skip to content

test(legacy[session]) Stabilize assertion #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2024
Merged

test(legacy[session]) Stabilize assertion #552

merged 2 commits into from
Dec 21, 2024

Conversation

tony
Copy link
Member

@tony tony commented Dec 21, 2024

Fixes #551

@tony tony force-pushed the stabilize-test-select-window-test branch from b246a20 to 1fc3789 Compare December 21, 2024 03:58
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (274d4c9) to head (b11ef11).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   88.75%   88.74%   -0.01%     
==========================================
  Files          36       36              
  Lines        3920     3917       -3     
  Branches      359      359              
==========================================
- Hits         3479     3476       -3     
  Misses        305      305              
  Partials      136      136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tony added 2 commits December 20, 2024 22:01
@tony
test(legacy[session]) Stabilize assertion
29c2e74 
=================================== FAILURES ===================================
______________________________ test_select_window ______________________________
[gw0] linux -- Python 3.13.0 /home/runner/work/libtmux/libtmux/.venv/bin/python
tests/legacy_api/test_session.py:51: in test_select_window
    assert selected_window1.__dict__ == attached_window1.__dict__
E   AssertionError: assert {'active_wind...e': None, ...} == {'active_wind...e': None, ...}
E
E     Omitting 125 identical items, use -vv to show
E     Differing items:
E     {'cursor_x': '0'} != {'cursor_x': '56'}
E     Use -v to get more diff
        attached_window1 = Window(@1 1:bash, Session($1 libtmux_yphmur0x))
        selected_window1 = Window(@1 1:bash, Session($1 libtmux_yphmur0x))
        session    = Session($1 libtmux_yphmur0x)
        window_base_index = 1
        window_count = 2
        window_idx = '1'

---------- coverage: platform linux, python 3.13.0-final-0 -----------
Coverage XML written to file coverage.xml

=========================== short test summary info ============================
FAILED tests/legacy_api/test_session.py::test_select_window - AssertionError: assert {'active_wind...e': None, ...} == {'active_wind...e': None, ...}

  Omitting 125 identical items, use -vv to show
  Differing items:
  {'cursor_x': '0'} != {'cursor_x': '56'}
  Use -v to get more diff
============= 1 failed, 439 passed, 12 skipped, 2 rerun in 17.[92](https://github.com/tmux-python/libtmux/actions/runs/12441319490/job/34738031175#step:12:93)s ==============

============================= test session starts ==============================
created: 4/4 workers
4 workers [452 items]

........................................................................ [ 15%]
.....s...............................................s.s................ [ 31%]
..............................................s...R........R.......Fs.s. [ 47%]
.................................................R..s...........ss...... [ 63%]
.......................s..s.....s.....................s.s.s..s....s.s... [ 78%]
........................................................................ [ 94%]
.......................                                                  [100%]
=================================== FAILURES ===================================
______________________________ test_select_window ______________________________
[gw0] linux -- Python 3.13.0 /home/runner/work/libtmux/libtmux/.venv/bin/python
tests/legacy_api/test_session.py:61: in test_select_window
    assert selected_window2.__dict__ == attached_window2.__dict__
E   AssertionError: assert {'active_wind...e': None, ...} == {'active_wind...e': None, ...}
E
E     Omitting 125 identical items, use -vv to show
E     Differing items:
E     {'cursor_x': '0'} != {'cursor_x': '56'}
E     Use -v to get more diff
        attached_window1 = Window(@1 1:bash, Session($1 libtmux__xf1mgsj))
        attached_window2 = Window(@2 2:test_window, Session($1 libtmux__xf1mgsj))
        selected_window1 = Window(@1 1:bash, Session($1 libtmux__xf1mgsj))
        selected_window2 = Window(@2 2:test_window, Session($1 libtmux__xf1mgsj))
        session    = Session($1 libtmux__xf1mgsj)
        window_base_index = 1
        window_count = 2
        window_idx = '1'
=============================== warnings summary ===============================
src/libtmux/pane.py::libtmux.pane.Pane.kill
  <doctest libtmux.pane.Pane.kill[4]>:1: UserWarning: resize() requires tmux 2.9 or newer

tests/legacy_api/test_window.py::test_split_window_size
  /home/runner/work/libtmux/libtmux/tests/legacy_api/test_window.py:185: UserWarning: resize() requires tmux 2.9 or newer
    window.resize(height=100, width=100)

tests/legacy_api/test_window.py::test_split_percentage
  /home/runner/work/libtmux/libtmux/tests/legacy_api/test_window.py:1[68](https://github.com/tmux-python/libtmux/actions/runs/12440365752/job/34735725442#step:12:69): UserWarning: resize() requires tmux 2.9 or newer
    window.resize(height=100, width=100)

tests/test_pane.py::test_split_pane_size
  /home/runner/work/libtmux/libtmux/tests/test_pane.py:279: UserWarning: resize() requires tmux 2.9 or newer
    window.resize(height=100, width=100)

tests/test_window.py::test_split_size
  /home/runner/work/libtmux/libtmux/tests/test_window.py:182: UserWarning: resize() requires tmux 2.9 or newer
    window.resize(height=100, width=100)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

---------- coverage: platform linux, python 3.13.0-final-0 -----------
Coverage XML written to file coverage.xml

=========================== short test summary info ============================
FAILED tests/legacy_api/test_session.py::test_select_window - AssertionError: assert {'active_wind...e': None, ...} == {'active_wind...e': None, ...}

  Omitting 125 identical items, use -vv to show
  Differing items:
  {'cursor_x': '0'} != {'cursor_x': '56'}
  Use -v to get more diff
======= 1 failed, 433 passed, 18 skipped, 5 warnings, 3 rerun in 17.00s ========
@tony
docs(CHANGES) Note test_select_window stability fix
b11ef11
@tony tony force-pushed the stabilize-test-select-window-test branch from 0480729 to b11ef11 Compare December 21, 2024 04:01
@tony tony merged commit da9ce78 into master Dec 21, 2024
27 checks passed
@tony tony deleted the stabilize-test-select-window-test branch December 21, 2024 04:06
tony added a commit that referenced this pull request Dec 21, 2024
@tony
test(legacy[session]) Stabilize assertion (#552)
7fbc23a 
Fixes #551.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test: test_select_window
1 participant
@tony