Skip to content

Fix segmentation time pad test#569

Merged
freemansw1 merged 1 commit intotobac-project:RC_v1.6.xfrom
freemansw1:fix_segmentation_tests
Mar 16, 2026
Merged

Fix segmentation time pad test#569
freemansw1 merged 1 commit intotobac-project:RC_v1.6.xfrom
freemansw1:fix_segmentation_tests

Conversation

@freemansw1
Copy link
Copy Markdown
Member

Resolves #565 by removing the i_time line (which does not belong) from the feature detection call.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 requested a review from fsenf March 11, 2026 02:47
@freemansw1 freemansw1 changed the base branch from main to RC_v1.6.x March 11, 2026 02:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.86%. Comparing base (8639ece) to head (4c6cfa7).
⚠️ Report is 2 commits behind head on RC_v1.6.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.6.x     #569   +/-   ##
==========================================
  Coverage      64.86%   64.86%           
==========================================
  Files             27       27           
  Lines           4047     4047           
==========================================
  Hits            2625     2625           
  Misses          1422     1422           
Flag Coverage Δ
unittests 64.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

Linting results by Pylint:

Your code has been rated at 8.36/10 (previous run: 8.36/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the main branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@fsenf fsenf added this to the v.1.6.4 milestone Mar 13, 2026
Copy link
Copy Markdown
Member

@fsenf fsenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctly done, thanks

@fsenf
Copy link
Copy Markdown
Member

fsenf commented Mar 15, 2026

@freemansw1 : please go ahead and merge

@freemansw1 freemansw1 merged commit 9564d7f into tobac-project:RC_v1.6.x Mar 16, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in Segmentation Testing

2 participants