BUG: Correct Bash completion path in Makefile #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To verify that these steps succeed on the workflow runners. This currently fails because of todotxt#451
To remove the duplication.
inkarkat
force-pushed
the
451-fix-bash-completion
branch
2 times, most recently
from
0395af6 to
96430e6
Compare
ss-raicangu
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
🙌 Thanks for the quick fix! Confirming that both sudo make install and sudo make uninstall works for me, including completion.
- suggestion: Possibly worth leaving a comment about why ignoring errors from
rmdir $(datarootdir)is acceptable. For example,# Cleaning up `datarootdir` if it only contains `todo.sh` completion. Otherwise, ignoring the error to allow `make uninstall` to finish.
[1] Pleasantly surprised that I'm able to approve/leave feedback.
karbassi
approved these changes
Dec 29, 2024
Unlike the other directories, this is a shared one; if there are other (locally installed) completions, it's not empty and cannot be removed. But if we're the only / last locally installed completion, it's nice to clean it up. Suppress errors and command failure so that "make uninstall" does not fail due to this inconsequential error. Fixes todotxt#451
…pletions /usr/share/bash-completion/bash_completion looks into /usr/[local/]share/bash-completion/completions/; the bash_completion.d is the legacy (statically sourced) location in /etc. This was overlooked when moving away from that. That change also failed to update the default location in the readme. (But the override example in the readme already used the correct one?!)
…on for completion Add a note that the legacy locations (now also consistently used for the completion script) are not recommended, just to illustrate how to override the default locations.
inkarkat
force-pushed
the
451-fix-bash-completion
branch
from
96430e6 to
5b8c3d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done:
master.make uninstallfails because it tries tormdirnon-emptybash_completion.d#451 reference to the issue that this pull request fixes.The correct one is
/usr/local/share/bash-completion/completions/todo.sh; previous adaptations away from the legacy/etc/bash_completion.d/todolocation were incomplete, also due to duplication in the Makefile.