Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esp32-tester. #2680

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Add esp32-tester. #2680

merged 3 commits into from
Dec 17, 2024

Conversation

floitsch
Copy link
Member

No description provided.

@floitsch floitsch requested a review from kasperl December 13, 2024 18:00
@cla-bot cla-bot bot added the cla-signed The contributors have signed the CLA label Dec 13, 2024
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

network := net.open
server-socket := network.tcp-listen 0
print "$network.address:$server-socket.local-address.port"
print "MINI-JAG LISTENING"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the constant from shared.toit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

import uart
import .shared

MINI-JAG-LISTENING ::= "MINI-JAG LISTENING"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the constant from shared.toit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

import .shared

MINI-JAG-LISTENING ::= "MINI-JAG LISTENING"
TEST-STARTED ::= "TEST STARTED"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.
done.


MINI-JAG-LISTENING ::= "MINI-JAG LISTENING"
TEST-STARTED ::= "TEST STARTED"
ALL-TEST-DONE ::= "All tests done"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ALL-TEST-DONE ::= "All tests done"
ALL-TESTS-DONE ::= "All tests done"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

collected-output += data.to-string-non-throwing
if not ready-latch.has-value and collected-output.contains "\n$MINI-JAG-LISTENING":
ready-latch.set true
if not all-tests-done.has-value and collected-output.contains ALL-TEST-DONE:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not all-tests-done.has-value and collected-output.contains ALL-TEST-DONE:
if not all-tests-done.has-value and collected-output.contains ALL-TESTS-DONE:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@floitsch floitsch enabled auto-merge (squash) December 17, 2024 14:44
@floitsch floitsch merged commit 59734da into master Dec 17, 2024
12 of 29 checks passed
@floitsch floitsch deleted the floitsch/run-hw-tests.20.mini-jag branch December 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The contributors have signed the CLA
Development

Successfully merging this pull request may close these issues.

2 participants