Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow expressions to return string and boolean values #3084

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LukeFinch
Copy link
Contributor

@LukeFinch LukeFinch commented Aug 17, 2024

What does this pull request do?

Currently, we're unable to use logic to return boolean values or strings when using expr-eval

  • Evaluated can be number, string or boolean.
  • Added tests for string and boolean expressions

Testing this change

{
  "str": {
    "value": "true ? 'yes' : 'no'",
    "type": "other"
  },
  "three-bigger-than-two": {
    "value": "3 > 2 ? true : false",
    "type": "other"
  }
}

Create these tokens, values should return yes and true
In previous versions, checkAndEvaluateMaths would not parse these values properly.

Additional Notes (if any)

I'm also looking into how arrays could be handled, as I feel the map() function from expr-eval could be useful

Copy link

changeset-bot bot commented Aug 17, 2024

🦋 Changeset detected

Latest commit: d3cd026

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant