Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gitlab commit message error #3238

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Conversation

akshay-gupta7
Copy link
Contributor

@akshay-gupta7 akshay-gupta7 commented Dec 30, 2024

Why does this PR exist?

Fixes a very specific issue in gitlab sync, where in when a user is trying to load tokens in a repo, the "Initial Commit" message is causing an error because the commit message is not in line with the user's company's commit message rules.

Addresses #3239

What does this pull request do?

This PR replaces the 'Initial commit' message with the message the user puts in for their first commit instead

Testing this change

  • Create a repo in Gitlab with commit message rules regex
  • Push the tokens to the repository following the message format
  • It should now sync normally as expected without throwing an error unless the user's message in not conforming to the commit message policy

Additional Notes (if any)

https://tokens-studio.slack.com/archives/C08674X9DHU/p1735214682471059?thread_ts=1735214100.463429&cid=C08674X9DHU

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 6f20d64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 30, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Dec 30, 2024

Commit SHA:99c8055a38a73552c06e84a6966ef32bea86e17e
No changes to code coverage between the base branch and the head branch

@akshay-gupta7 akshay-gupta7 self-assigned this Dec 30, 2024
@akshay-gupta7 akshay-gupta7 marked this pull request as ready for review December 31, 2024 07:00
@akshay-gupta7 akshay-gupta7 requested a review from six7 December 31, 2024 07:00
@akshay-gupta7 akshay-gupta7 linked an issue Dec 31, 2024 that may be closed by this pull request
@akshay-gupta7 akshay-gupta7 changed the title fix commit message error fix gitlab commit message error Dec 31, 2024
@akshay-gupta7 akshay-gupta7 merged commit 62dced0 into main Dec 31, 2024
10 checks passed
@akshay-gupta7 akshay-gupta7 deleted the gitlab-commit-rule-issue branch December 31, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab sync failing with commit rules
2 participants