Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitlab bug, gitkeep file created on every commit #3268

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

akshay-gupta7
Copy link
Contributor

Why does this PR exist?

Fixes an issue in Gitlab sync. When a user pushes a change as a commit, gitkeep file is being created, leading to 3 commits for each change.

What does this pull request do?

Testing this change

  • Create a sync in Gitlab Repo
  • Make a change
  • Commit the change
  • It should now be only one commit(if gitkeep file was already removed previously)

Additional Notes (if any)

@akshay-gupta7 akshay-gupta7 self-assigned this Feb 17, 2025
Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 39a4d23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 17, 2025

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

@akshay-gupta7 akshay-gupta7 marked this pull request as draft February 17, 2025 20:22
Copy link
Contributor

github-actions bot commented Feb 17, 2025

Commit SHA:ce377f0701393ddbcde78a7ec60fefb77ee0cb01
No changes to code coverage between the base branch and the head branch

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Commit SHA:406099da12e34e978ccd5292172d4fdd648e17f8
Current PR reduces the test coverage percentage by 1 for some tests

@akshay-gupta7 akshay-gupta7 marked this pull request as ready for review February 17, 2025 20:51
Copy link
Collaborator

@six7 six7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you get a review from Keegan or Robbert?

@akshay-gupta7
Copy link
Contributor Author

can you get a review from Keegan or Robbert?

yes I have sent it to Keegan and one of our users Andy Sobol as well to confirm, I will wait for their feedback before merging

@akshay-gupta7 akshay-gupta7 merged commit 1914658 into main Feb 24, 2025
9 checks passed
@akshay-gupta7 akshay-gupta7 deleted the fix-gitkeep-issue branch February 24, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants