-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate rail component styles to use utils #621
base: master
Are you sure you want to change the base?
Conversation
- Create rail.module.css for component-specific styles - Add data-appearance and data-emphasis attributes
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@@ -0,0 +1,7 @@ | |||
.stack { | |||
background: var(--color-neutral-canvas-minimal-bg); | |||
border-right: 1px solid var(--color-neutral-stroke-default); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be var(--component-border-width-md) solid var(--stroke-default)
i would change the stroke-default to subtle
@@ -0,0 +1,7 @@ | |||
.stack { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call the class rail to be more explicit
padding: | ||
'var(--component-spacing-xl) var(--component-spacing-md) var(--component-spacing-md)' | ||
}} | ||
className={clsx(styles.stack, 'ts-canvas')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the class here
User description
PR Type
Enhancement
Description
Migrated inline styles to CSS module for
Rail
component.Added
clsx
for conditional class name management.Introduced
data-appearance
anddata-emphasis
attributes for styling.Created
rail.module.css
for component-specific styles.Changes walkthrough 📝
rail.tsx
Refactor `Rail` component to use CSS modules
packages/ui/src/components/rail.tsx
clsx
for managing class names dynamically.data-appearance
anddata-emphasis
attributes.rail.module.css
Add CSS module for `Rail` component styles
packages/ui/src/components/rail.module.css
.stack
class for padding and border-radius styles.Rail
component-specific styles.