Skip to content

Conversation

@hulxv
Copy link
Contributor

@hulxv hulxv commented Oct 13, 2025

Fix #1905

@Darksonn
Copy link
Contributor

Can we also add a test that mio::event::Event implements Send/Sync somewhere? That way, whenever we add a new platform, we have to at least think about whether it should be Send/Sync if it isn't already.

@hulxv
Copy link
Contributor Author

hulxv commented Oct 14, 2025

Can we also add a test that mio::event::Event implements Send/Sync somewhere? That way, whenever we add a new platform, we have to at least think about whether it should be Send/Sync if it isn't already.

Is that fine?

https://github.com/tokio-rs/mio/pull/1906/files#diff-40119742cba31026e7fe170d6ad1d05c82b31f302f335386f39142a1df7c023dR944-R973

@hulxv hulxv requested a review from Darksonn October 14, 2025 13:50
@hulxv hulxv requested a review from Thomasdezeeuw October 16, 2025 15:10
@Thomasdezeeuw
Copy link
Collaborator

@hulxv you code didn't compile so I send some commits to fix that and apply some of the suggestions I was going to make anyway. I'll merge this and release this today.

Thanks for your contribution!

@Thomasdezeeuw Thomasdezeeuw merged commit 8c0b1ff into tokio-rs:master Oct 17, 2025
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macos: *mut c_void cannot be sent between threads safe

3 participants