Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove new reddit platform handling #1028

Merged
merged 5 commits into from
Dec 14, 2024
Merged

remove new reddit platform handling #1028

merged 5 commits into from
Dec 14, 2024

Conversation

eritbh
Copy link
Member

@eritbh eritbh commented Dec 14, 2024

Aside from the "open in new reddit" button that was already handled in #1025, there's not actually a whole lot of dead code we can remove by not supporting new Reddit. We still rely on the combination of TBListener + the oldreddit module for a bunch of UI stuff in old Reddit; eventually #940 will replace both with a new system and everything will be changed to use that instead, but that's not happening here. A couple features specific to new Reddit were removed, and the modbar overlayFromBarRedesign setting (which controls whether clicking queue buttons in the modbar on new reddit opens the queue as an overlay or acts as a normal link) now applies to shreddit instead.

Fixes #1027

@eritbh
Copy link
Member Author

eritbh commented Dec 14, 2024

branch updated to actually remove the lightbox setting and purge it from storage. Also cleaned up the related purges of removed settings - located them all together in a single Promise.all, and makes sure that they're purged regardless of the version we're updating from, since it's cheap to delete things even if they already don't exist

@eritbh eritbh merged commit a4b2e43 into master Dec 14, 2024
3 checks passed
@eritbh eritbh deleted the chore/nuke-new-reddit branch December 14, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for new.reddit.com
1 participant