Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User flair in macros #680

Merged
merged 4 commits into from
Dec 4, 2022
Merged

User flair in macros #680

merged 4 commits into from
Dec 4, 2022

Conversation

rysie
Copy link
Contributor

@rysie rysie commented Nov 16, 2022

This pull request adds mod macro option for assigning a user an existing user flair.

image

image

@eritbh eritbh self-requested a review November 16, 2022 17:15
@eritbh eritbh added enhancement New feature or request module: macros labels Nov 16, 2022
eritbh
eritbh requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@eritbh eritbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, though I haven't done any local testing yet. I only see one thing that needs to be addressed.

It looks like a lot of this logic could also be reused to enable a similar post flair feature - though that would also require additional logic to not act on comments. We do something similar already for modmail-specific actions, but I think that should probably be its own PR rather than making it a part of this one. @creesch if you think that's a good feature to add I can make an issue for it.

extension/data/modules/macros.js Outdated Show resolved Hide resolved
@creesch
Copy link
Member

creesch commented Nov 16, 2022

Looks good to me as well, but I also haven't verified functionality locally.

@eritbh I was thinking the same thing about also having it for posts. But doesn't have to be in this PR so an issue to track it seems like a good idea.

@eritbh eritbh mentioned this pull request Nov 16, 2022
Open
@eritbh
Copy link
Member

eritbh commented Nov 16, 2022

...so an issue to track it seems like a good idea.

#682 created

eritbh
eritbh requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@eritbh eritbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My local test did find one more thing...

extension/data/modules/macros.js Show resolved Hide resolved
eritbh
eritbh approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@eritbh eritbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my machine! Thanks for the PR~

@rysie
Copy link
Contributor Author

rysie commented Nov 16, 2022

All good on my machine! Thanks for the PR~

Lovely! Thanks for checking.

@creesch creesch merged commit ad99ab0 into toolbox-team:master Dec 4, 2022
@eritbh eritbh added this to the v6.1.0 milestone Dec 6, 2022
eritbh added a commit that referenced this pull request Sep 5, 2024
@rysie @eritbh
User flair in macros (#680)
792b189 
* Mod Macro add-on: flair user

* Mod Macro add-on: flair user

* Update extension/data/modules/macros.js

Co-authored-by: Erin <[email protected]>

* Mod Macro add-on: flair user, non-modmail action

Co-authored-by: Erin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eritbh eritbh eritbh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request module: macros
Projects
None yet
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rysie @creesch @eritbh