Exclude PYTHONPATH when invoking install, as it won't be present when invoking tests. #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… invoking tests. Ref tox-dev#330.
|
@jaraco any idea how to test that one? |
|
I did test it in situ, but I suspect doing it as a unit test or functional test would be an awful lot of work -- probably more than it's worth. You could possibly do some mocks and validate that PYTHONPATH gets removed during that call, but I think the code speaks pretty well for itself. The logic hasn't changed - only the data that drives the logic. I suggest accepting it without a unit test. |
|
at first glance i suspect this will break things in |
|
i believe my first suspicion is wrong, i will test on nix later on |
|
Excellent. Thanjs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330.