bug: fix const correctness bugs#301
Merged
williamcroberts merged 5 commits intoJul 4, 2026
Merged
Conversation
Because this library targets OpenSSL versions less than 3, we don't want the build cluttered with warnings about deprecated functions. Thus ignore them. Signed-off-by: Bill Roberts <bill.c.roberts@gmail.com>
williamcroberts
force-pushed
the
fix-ci-build-2
branch
from
1f3eb04 to
d911f2f
Compare
OpenSSL has added some const specifiers to their function in version 3 that are missing in version 2. This causes all sorts of invalid target pointer warnings on function pointers. To fix this, make the interfaces match what OpenSSL expects for its version. Signed-off-by: Bill Roberts <bill.c.roberts@gmail.com>
Signed-off-by: Bill Roberts <bill.c.roberts@gmail.com>
williamcroberts
force-pushed
the
fix-ci-build-2
branch
from
61d1ce0 to
aa90217
Compare
leap always moves to the bleeding edge, so we don't want to keep trying to figure out how to use the deprecated engine with the bleeding edge versions. Signed-off-by: Bill Roberts <bill.c.roberts@gmail.com>
We can't support this container anymore, it's out of date. We will need to create a new container for a more testing this arch again. Signed-off-by: Bill Roberts <bill.c.roberts@gmail.com>
Member
Author
|
Ok this green lights our CI and patch flow again, so I am going to go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions, including callbacks, had const in them, while not quite right, they were not quite wrong either, but older OpenSSL was notoriously full of places where const should have been used. So, to keep the patch simple and so we don't have to cast function pointers, drop const.