Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pkgs.dockerToolsを利用する #109

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat: pkgs.dockerToolsを利用する #109

merged 3 commits into from
Oct 21, 2024

Conversation

mtaku3
Copy link
Contributor

@mtaku3 mtaku3 commented Oct 19, 2024

close #108

pkgs.dockerTools を使って再実装

nix build でビルドして docker load -i result でDockerにイメージをロードできます。

image

image

@mtaku3 mtaku3 requested a review from comavius October 19, 2024 15:26
@comavius comavius added the nix label Oct 19, 2024
comavius
comavius reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@comavius comavius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点だけ確認したいことがあって、コンパイラはexec-container/compilersに入れることを想定していますか？

@mtaku3
Copy link
Contributor Author

mtaku3 commented Oct 20, 2024

その想定です。一応nixpkgsがinterpretersとcompilersでディレクトリを分けていたのでそれに沿う意図です。
コードの方もcompilersを追加しておきました。

@comavius comavius self-requested a review October 20, 2024 04:25
@mtaku3 mtaku3 merged commit c6ee854 into develop Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comavius comavius comavius approved these changes

Assignees
No one assigned
Labels
nix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkgs.dockerToolsを利用する
2 participants
@mtaku3 @comavius