8 bit AdamW optimizer#5153
Open
Redhawk18 wants to merge 25 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Decreases memory usage, a major problem in Burn.
Changes
Summarize the problem being addressed and your solution.
Adds two impls of 8 bit optimizers based on Tim Dettmers, the tensor operation one is mostly just an artifact of in progress work. The 8 bit kernel is the one that improves results overall.
Testing
Describe how these changes have been tested.
Unit testing everywhere, then the optimizers were compared directly with this integration benchmark that also produces figures.
Loss for the synthetic benchmark



Wikitext 2 benchmark



Table: Comparison of optimizer implementations at learning rate 1e-4: average step time (with standard deviation), optimizer state size, and average process memory.