-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract markers into plugin #1687
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could we also add a short documentation page for the plugin?
- I know the graphics tests will fail because the interface changed. Did you manage to run the tests locally before the changes, save those images somewhere, and then run again with the current changes? If so, could you check that the screenshots are the same? It's a bit of pain to manually do this I guess. Downside of our current screenshot testing system.
|
I've checked all the screenshots. Fixed one small issue with margins that I've spotted in progress, and failing coverage tests are also fixed, I used wrong interface as returned type and ts-transformer renamed properties that should be public. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type of PR: enhancement
N/A
Addresses an existing issue: fixes #Overview of change:
Moved a series markers into a built-in plugin to enable tree shaking