Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v5 into master for Version 5.0.0 Release #1788

Merged
merged 216 commits into from
Jan 29, 2025
Merged

Merge v5 into master for Version 5.0.0 Release #1788

merged 216 commits into from
Jan 29, 2025

Conversation

SlicedSilver
Copy link
Contributor

@SlicedSilver SlicedSilver commented Jan 28, 2025

Overview

This PR merges the v5 branch into master in preparation for the official v5.0.0 release.

It is expected that the following will be failing on the pipeline (currently comparing against v5-candidate branch):

  • dts-changes
  • graphics-tests-part3

SlicedSilver and others added 30 commits January 12, 2024 20:54
circle CI not building correctly before type-tests check

Revert changes to circleci

remove module setting for type-checks test

try fix the circle-ci type-checks test
* fix pane widget and separator feature previously implemented in 22c6b03

* Add prepare scripts to package.json

* Add empty .npmignore

This file is being used in conjunction with the `prepare` script.
See this for details: yarnpkg/yarn#5235 (comment)

* implement subscribePaneResize and unsubscribePaneResize

* add ChartApi#removePane and ChartApi#swapPane, update Series#applyOptions for pane option

* update .size-limit.js

* Update package.json

* Revert "implement subscribePaneResize and unsubscribePaneResize"

This reverts commit 2194ebc

* add ChartApi#getPaneElements()

* fix pane widget and separator feature previously implemented in 22c6b03

* implement subscribePaneResize and unsubscribePaneResize

* add ChartApi#removePane and ChartApi#swapPane, update Series#applyOptions for pane option

* Revert "implement subscribePaneResize and unsubscribePaneResize"

This reverts commit 2194ebc

* add ChartApi#getPaneElements()

* update .size-limit.js and linter errors

* add paneIndex to MouseEventParams (click and crosshair event)

* add nonPrimaryPriceScale to ChartOptions for non primary pane

* fix: resize panes

* fix: remove empty panes

* fix: be able to move series to 0 index pane

* fix: paneSize method receive paneIndex

* chore: add method description

* update size limit

* add basic e2e tests

* add coverage tests

* add coverage test

* add customisable options

* improve coverage

* add PaneApi

* add paneApi coverage test

* remove dedicated pane options

* rename method

* remove pane index mapping

* remove paneIndex from series options

* fix tests

* fix line series

* remove PaneInfo interface

* remove paneIndex from Series

* cleanup removePane and swapPane

* fix crosshair horizontal line on all panes

* fix prevent removing last pane

* fix: remove non-primary price scale

* cleanup

* Pane separator & panes resize improvements

* fix add jsdoc comment

* fix: rename details to point

* remove getPaneElements api

* add CrosshairMarksPaneView per pane

* cleanup tests

* fix invalidation

* fix CrosshairMarksPaneView order

* add getSeriesByPane and getPaneBySeries apis

* add series method to pane

* update size limit

* createSeries fix

* add PaneApi getHTMLElement + change getSeriesByPane

* rename method

* add integration tests

* fix: remove methods from ChartApi

* Update src/api/iseries-api.ts

Co-authored-by: Mark Silverwood <[email protected]>

* Update src/model/chart-model.ts

Co-authored-by: Mark Silverwood <[email protected]>

* fixed code review suggestions

* move method to private

* Update src/api/ichart-api.ts

Co-authored-by: Mark Silverwood <[email protected]>

* fix paneIndex types

* change iseries-api description

* add how to guide

* add sidebar page

* add documentation links

* fix multiple logos

* add e2e tests

* add docs suggestions

* fix links

* fix docs links

* Update website/tutorials/how_to/panes.mdx

Co-authored-by: Evgeniia Riazanova <[email protected]>

* update docs

* fix markdown formatting

* add tm signs

* fix typo

* rename createPane method

* make getOrCreatePane private

* _getOrCreatePane refactoring

* fix: series priceScaleId option

* fix: add target blank to attr-logo

* test: disable attribution logo on unrelated tests

---------

Co-authored-by: Adrian Ng <[email protected]>
Co-authored-by: Kirill Chetverikov <[email protected]>
Co-authored-by: Mark Silverwood <[email protected]>
Co-authored-by: Evgeniia Riazanova <[email protected]>
…x-support

Enable device pixel content box support
@SlicedSilver SlicedSilver added bug Unexpected problem or unintended behavior. enhancement Feature requests, and general improvements. tests Unit and e2e testing. documentation Improvements or additions to the documentation breaking change Changes the API in a non backwards compatible way. infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts). website Related to the documentation website, but not it’s content. plugin This feature request should/could be implemented as a Plugin. labels Jan 28, 2025
@SlicedSilver SlicedSilver added this to the 5.0 milestone Jan 28, 2025
@SlicedSilver SlicedSilver self-assigned this Jan 28, 2025
@SlicedSilver SlicedSilver changed the title Merge v5-candidate into master for Version 5.0.0 Release Merge v5 into master for Version 5.0.0 Release Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

size-limit report 📦

Path Size
CJS 0 B (-100% 🔽)
ESM 44.84 KB (-6.83% 🔽)
Standalone-ESM 46.32 KB (-7.02% 🔽)
Standalone 46.26 KB (-7.2% 🔽)
ESM createChart 36.8 KB (+100% 🔺)
ESM createChartEx 35.62 KB (+100% 🔺)
ESM createYieldCurveChart 37.03 KB (+100% 🔺)
ESM createOptionsChart 35.76 KB (+100% 🔺)
Plugin: Text Watermark 1.87 KB (+100% 🔺)
Plugin: Image Watermark 1.69 KB (+100% 🔺)
Plugin: Series Markers 3.98 KB (+100% 🔺)
Series: LineSeries 2.54 KB (+100% 🔺)
Series: BaselineSeries 3.2 KB (+100% 🔺)
Series: AreaSeries 3.12 KB (+100% 🔺)
Series: BarSeries 2.15 KB (+100% 🔺)
Series: CandlestickSeries 2.42 KB (+100% 🔺)
Series: HistogramSeries 2.18 KB (+100% 🔺)
Plugin: UpDownMarkersPrimitive 2.37 KB (+100% 🔺)

@vishnuc
Copy link

vishnuc commented Jan 28, 2025

HI , when is it releasing , I am so eager

@SlicedSilver
Copy link
Contributor Author

@vishnuc

HI , when is it releasing , I am so eager

'Soon...' but if you want to use it today then npm install lightweight-charts@next-v5 will install 5.0.0-rc2 which is 99.9% the same as what the final release will likely be. The 'delay' is due to additional QA testing to ensure everything works as expected across the multiple projects which use LWC as a dependency.

@vishnuc
Copy link

vishnuc commented Jan 28, 2025

I am waiting for documentation for v5 ,, so I will wait .. hope its very "sooon.."

@SlicedSilver SlicedSilver marked this pull request as ready for review January 29, 2025 12:55
@SlicedSilver SlicedSilver merged commit a78cb4c into master Jan 29, 2025
27 of 33 checks passed
@SlicedSilver SlicedSilver deleted the v5 branch January 29, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes the API in a non backwards compatible way. bug Unexpected problem or unintended behavior. documentation Improvements or additions to the documentation enhancement Feature requests, and general improvements. infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts). plugin This feature request should/could be implemented as a Plugin. tests Unit and e2e testing. website Related to the documentation website, but not it’s content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants