Support AWS Instance Profile & Use boto3 best practice in session creation#561
Open
amigold wants to merge 6 commits into
Open
Support AWS Instance Profile & Use boto3 best practice in session creation#561amigold wants to merge 6 commits into
amigold wants to merge 6 commits into
Conversation
…he image + README.md update
merge from master
According to the docs boto3 will try getting credentials from several places including env vars, instance profile etc https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html
Bumps [snowflake-connector-python](https://github.com/snowflakedb/snowflake-connector-python) from 2.3.6 to 3.0.2. - [Release notes](https://github.com/snowflakedb/snowflake-connector-python/releases) - [Commits](snowflakedb/snowflake-connector-python@v2.3.6...v3.0.2) --- updated-dependencies: - dependency-name: snowflake-connector-python dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…-python-3.0.2 Bump snowflake-connector-python from 2.3.6 to 3.0.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently pipelinewise does not support taking AWS credentials from instance profile and not using boto3 best practices in terms of credential creation
Proposed changes
Simply use best practice mentioned here https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html
In order to support instance profile credentials as well
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
xin the boxes that applyChecklist
setup.pyis an individual PR and not mixed with feature or bugfix PRs[AP-NNNN](if applicable. AP-NNNN = JIRA ID)AP-NNN(if applicable. AP-NNN = JIRA ID)