Skip to content

Support AWS Instance Profile & Use boto3 best practice in session creation#561

Open
amigold wants to merge 6 commits into
transferwise:masterfrom
fairfly:master
Open

Support AWS Instance Profile & Use boto3 best practice in session creation#561
amigold wants to merge 6 commits into
transferwise:masterfrom
fairfly:master

Conversation

@amigold

@amigold amigold commented Oct 25, 2020

Copy link
Copy Markdown
Contributor

Problem

Currently pipelinewise does not support taking AWS credentials from instance profile and not using boto3 best practices in terms of credential creation

Proposed changes

Simply use best practice mentioned here https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html
In order to support instance profile credentials as well

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

amigold and others added 6 commits September 21, 2020 15:10
According to the docs boto3 will try getting credentials from several places including env vars, instance profile etc
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html
Bumps [snowflake-connector-python](https://github.com/snowflakedb/snowflake-connector-python) from 2.3.6 to 3.0.2.
- [Release notes](https://github.com/snowflakedb/snowflake-connector-python/releases)
- [Commits](snowflakedb/snowflake-connector-python@v2.3.6...v3.0.2)

---
updated-dependencies:
- dependency-name: snowflake-connector-python
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…-python-3.0.2

Bump snowflake-connector-python from 2.3.6 to 3.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant