Fixing that each document will return true for \ifmonograph besides \if[pubtype] #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @LupinoTech.
I found an issue with the pubtype parameter in the CoCoTeX document class. With the current pubtype choice definition, where the initial/default value is
mono
,\ifmonograph
will always returntrue
, no matter which pubtype has been set in the document parameters. However, the\if[pubtype]
that corresponds to the set pubtype will also returntrue
. Putting the initial valuemono
for the respective choice key to the top fixes that issue.Please evaluate that and merge if you can confirm that my fix is valid. An MWE for testing the issue is below:
Kind regards,
Marcus