Update db-setup.yml #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clekstro
reviewed
Feb 25, 2020
| @@ -1,19 +1,12 @@ | |||
| dist: bionic | |||
There was a problem hiding this comment.
I don't know how a potential conflict will be resolved here. Is it the build env that appears last in the file, i.e. dependent on where the shared config is injected? Depending on how this works, it may break other apps that rely on a different version of the build environment. This may not be a big deal to fix though.
@DamianSzymanski Have you tried these changes in isolation on any of the apps that inject this config to make sure it works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL is now preinstalled