Repository navigation
Keep the space before the number in numbering extra captions - #770
Open
RavSinghChandan wants to merge 1 commit into
Open
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
numberingextra drops the space between the caption text and the number:The wiki page shows
Table 1: some interesting stufffor this input. The space was lost in #387 (Regex DOS fixes), which removed the\s*around the text before@from the regex and added.strip(), so the trailing space went too. The text before@is now followed by a space when there is one, so[#c @x: caption]still gives1: caption.The
numberingtest case didn't catch this becausenumbering.textwas a copy of the expected HTML, so it never used the extra's syntax. It now has the[#counter text @id ...]definitions and[@id]references that producenumbering.html, which is unchanged; it fails on master.Added a line to CHANGES.md (I used #770 for the number; I'll correct it if the PR gets another one)