deprecate Compression::new
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Dec 18, 2024
folkertdev
force-pushed
the
validate-compression-level
branch
from
786feac to
910ab60
Compare
bjorn3
approved these changes
Feb 10, 2025
folkertdev
force-pushed
the
validate-compression-level
branch
from
910ab60 to
f23f556
Compare
bjorn3
reviewed
Feb 11, 2025
folkertdev
force-pushed
the
validate-compression-level
branch
from
f23f556 to
2d215be
Compare
folkertdev
force-pushed
the
validate-compression-level
branch
from
2d215be to
a5338b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #107
fixes #84
We could also just remove the bad methods with a major version bump, but this seems a little gentler and should make the problem go away in practice.