feat: extra headers during client initialization

[aderihoJD]

Unfortunately, this feature #568 not fully provide possibility to apply extra headers for each request to Trino. They apply only for the first one (query) and we lose them later, in next() method. If we'll add extraHeaders during client initialization, they will apply for each request.
p.s. pretty urgent, if possible

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: aderihoilya.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[regadas]

Hi @aderihoJD Thanks for this.

Can you add a test for it?

[aderihoJD]

Hi @aderihoJD Thanks for this.

Can you add a test for it?
@regadas not sure. I see a possible suite, that we can check that each request will apply with certain extra header, which we provide during client initialization. But we can't access request method.
Maybe u have some proposals about possible test suite?

[mosabua]

@aderihoJD please provide a signed CLA as well

[aderihoJD]

@aderihoJD please provide a signed CLA as well

i had to create a new one, as i did whole flow from another email #668

[mosabua]

@aderihoJD please provide a signed CLA as well

i had to create a new one, as i did whole flow from another email #668

Your CLA probably still has to be processed. Stay tuned. Also if you rebase your commit you can change author as well so theoretically you dont need a new PR. But either is fine and we need to wait until CLA is processed. Your github username will show up in https://github.com/trinodb/cla/blob/master/contributors

[aderihoJD]

@mosabua i appeared in this list https://github.com/trinodb/cla/blob/master/contributors
what is the next step?

[nineinchnick]

@cla-bot check

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: aderihoilya.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[nineinchnick]

There's an open discussion in trinodb/trino#15826 about allowing clients to send any HTTP headers. It would be better to discuss specific use cases.

Similar changes were suggested in both the Trino Go client, and the Python client, and both were rejected, because no sufficient use case was provided.

[nineinchnick]

BTW the CLA bot check is not passing, because the commit is authored by aderihoilya, which is not matching @aderihoJD username/email.

[aderihoJD]

@nineinchnick i created a new MR with correct user #668 - it's not a duplicate

[nineinchnick]

So can this one be closed then?