Skip to content

Use default TLS port if scheme is HTTPS #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nfantone
Copy link

@nfantone nfantone commented Apr 13, 2025

Description

Uses either DEFAULT_TLS_PORT (443) or DEFAULT_PORT (8080) if no explicit port is provided, based on the HTTP scheme of the connection URI.

Release notes

  • This is not user-visible or docs only and no release notes are required.
  • Release notes are required, please propose a release note for me.
  • Release notes are required, with the following suggested text:
* Use default TLS port if scheme is HTTPS. ({issue}`#539`)

Copy link

cla-bot bot commented Apr 13, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nfantone nfantone force-pushed the fix-default-tls-port branch from 3dafef7 to 5a09679 Compare April 13, 2025 14:37
Copy link

cla-bot bot commented Apr 13, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nfantone
Copy link
Author

Not sure what else to do here. The CLA was signed, sent and approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant