Repository navigation
fix(dbapi): require TLS when Authorization header is passed over HTTP - #653
Open
Shahzeb-DataEngineer wants to merge 1 commit into
Open
Shahzeb-DataEngineer wants to merge 1 commit into
Shahzeb-DataEngineer wants to merge 1 commit into
Conversation
The TLS-required check in Connection.__init__ only looked at the auth object, so credentials supplied as an Authorization header via http_headers or http_session.headers were sent in cleartext over HTTP before the server could reject them. Extend the check to those header paths (case-insensitive), still honouring allow_insecure_auth. Add unit tests for both header paths plus the HTTPS, opt-out and no-header cases. Closes trinodb#642 Signed-off-by: Shahzeb Ali <126076773+Shahzeb-DataEngineer@users.noreply.github.com>
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TLS-required check in
Connection.__init__only looked at theauthobject, so credentials supplied as anAuthorizationheader viahttp_headersor viahttp_session.headerswere sent in cleartext over HTTP before the server could reject them. This extends the check to those header paths (case-insensitive), still honouring theallow_insecure_authopt-out.Test plan
tests/unit/test_dbapi.py:Authorizationheader viahttp_session, viahttp_headers, lowercaseauthorizationkey, plus no-error cases for HTTPS,allow_insecure_auth=True, and a session with only a non-auth header.pytest tests/unit/test_dbapi.py -k auth: 10 passed. Full file: 43 passed; the 5 failures (test_token_retrieved_once_*x3,test_cursor_close_*x2) are pre-existing on pristine main (verified viagit stash).flake8 trino/dbapi.py tests/unit/test_dbapi.pyclean.Related Issue
closes #642