Fixes formatting issue for negated SQL subqueries #27678
Merged
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you please add a test? |
Member
Author
|
@ebyhr I meant to ask where a good place to add the test would be. I know Trino typically leans hard on integration tests, but this seems much better suited for a unit test. I see that there's a |
marcinsbd
reviewed
Dec 23, 2025
testing/trino-tests/src/test/java/io/trino/tests/TestSqlFormatter.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/TestSqlFormatter.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/TestSqlFormatter.java
Outdated
Show resolved
Hide resolved
JohnFitzpatrick44
force-pushed
the
jcf/fix-formatting-on-negation
branch
2 times, most recently
from
ffef46f to
18ab834
Compare
marcinsbd
reviewed
Jan 20, 2026
| private static Stream<String> sqlQueries() | ||
| { | ||
| return Stream.of( | ||
| "SELECT +1", |
Contributor
There was a problem hiding this comment.
just curious if the following would be a valid case:
(SELECT 1) + SELECT
(SELECT 1) - SELECT
Member
Author
There was a problem hiding this comment.
The SqlFormatter seems to correctly throw a syntax error for these cases
wendigo
reviewed
Jan 22, 2026
testing/trino-tests/src/test/java/io/trino/tests/TestSqlFormatter.java
Outdated
Show resolved
Hide resolved
JohnFitzpatrick44
force-pushed
the
jcf/fix-formatting-on-negation
branch
from
18ab834 to
1468546
Compare
JohnFitzpatrick44
force-pushed
the
jcf/fix-formatting-on-negation
branch
3 times, most recently
from
082289b to
aa33639
Compare
wendigo
force-pushed
the
jcf/fix-formatting-on-negation
branch
from
aa33639 to
1a3faec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19695 . Addresses issues with round-trips for negated subqueries. Specifically, the formatter adds parentheses around negative unary arithmetic expressions, even if the value being negated already has parentheses around it (i.e. for SQL subqueries).
This change just checks whether the value being negated is already wrapped in parentheses.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: