Add tests for PBE and Hadoop JCEKS global S3 credentials - #30798
Open
niteshy wants to merge 1 commit into
Open
Conversation
Test-only change covering both JCEKS entry layouts for global fs.s3a.access.key and fs.s3a.secret.key aliases: - PBE JCEKS (SecretKeyEntry via PBEKeySpec): unit tests for KeystoreSecretProvider and SecretsResolver, plus Hive DML product tests against MinIO with keystore-backed catalog credentials. Compatible with Trino's bundled Airlift 444. - Hadoop-format JCEKS (SecretKeySpec via CredentialProviderFactory setKeyEntry): unit test via KeyStoreTestFixture.createHadoopKeyStore, validated with secrets-keystore-plugin 445-SNAPSHOT (test scope only). Production Hadoop-format keystores require enhanced reader support in airlift/airlift#2100 and a subsequent Trino Airlift version bump — not a merge blocker for this test-only PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test-only change covering both JCEKS entry layouts for global fs.s3a.access.key and fs.s3a.secret.key aliases:
PBE JCEKS (SecretKeyEntry via PBEKeySpec): unit tests for KeystoreSecretProvider and SecretsResolver, plus Hive DML product tests against MinIO with keystore-backed catalog credentials. Compatible with Trino's bundled Airlift 444.
Hadoop-format JCEKS (SecretKeySpec via CredentialProviderFactory setKeyEntry): unit test via KeyStoreTestFixture.createHadoopKeyStore, validated with secrets-keystore-plugin 445-SNAPSHOT (test scope only).
Production Hadoop-format keystores require enhanced reader support in airlift/airlift#2100 and a subsequent Trino Airlift version bump — not a merge blocker for this test-only PR.
Additional context and related issues
Thanks for feedback by @dain @electrum in #30638 (comment). Added this airlift/airlift#2100 in Airlift. This PR is the follow-up to the discussion on #30638
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: