chore: replace yaml-rust with actively maintained yaml-rust2 #538
Conversation
|
Update: I was wrong it is in fact used 👍 |
Cargo.toml
Outdated
| @@ -18,7 +18,7 @@ exclude = [ | |||
| ] | |||
|
|
|||
| [dependencies] | |||
| yaml-rust = { version = "0.4.5", optional = true } | |||
| yaml-rust = { version = "0.4.5", optional = true, crate = "yaml-rust2" } | |||
There was a problem hiding this comment.
Can you point me to documentation on this property please? I can't find it at https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html
There was a problem hiding this comment.
Seems like it does not work. CI says: warning: unused manifest key: dependencies.yaml-rust.crate
There was a problem hiding this comment.
Maybe we can use one of the other PRs
There was a problem hiding this comment.
I have made a mistake in the PR
the key this PR is attempting to use is called package not crate, my apologies.
There was a problem hiding this comment.
No worries, I think we should use #544 though, it looks similar to the first PR to change to yaml2
|
Closing as #544 does the fix in a better fashion |
It would be worth investigating if the dependency is required at all, this simply replaces it with the
cratekey in theCargo.tomlwithyaml-rust2.TODO: update changelog when everything is sorted out 👍