opt(framework): delete useless code #6286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: imalasong <[email protected]>
Contributor
Author
|
I thought about it later, and if the exception is caused by the block itself, it seems necessary to retrieve it again. Whether to reacquire it or not, official personnel can discuss it |
b0900062030
approved these changes
May 2, 2025
Contributor
|
Thank you for your submission! After evaluating it, we have decided to leave it as is in order to deal with the anomaly. We sincerely appreciate your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
getBlockByNum() is useless in this place，He should completely hand it over to the producer getBlock() method
Why are these changes required?
This PR has been tested by:
Follow up
Extra details