Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133930 / 25.10 / Clean-up device info plugin #15550

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

NAS-133930 / 25.10 / Clean-up device info plugin #15550

wants to merge 4 commits into from

Conversation

yocalebo
Copy link
Contributor

@yocalebo yocalebo commented Feb 1, 2025

This cleans up the device info module.

  1. remove methods that were only used in unit tests? The actual method wasn't called anywhere...
  2. remove methods that aren't called anywhere else
  3. move the tty serial information to ups module since that's the only caller
  4. remove unused imports

@yocalebo yocalebo requested a review from a team February 1, 2025 13:18
@bugclerk
Copy link
Contributor

bugclerk commented Feb 1, 2025

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133930

@bugclerk bugclerk changed the title Clean-up device info plugin NAS-133930 / 25.10 / Clean-up device info plugin Feb 1, 2025
@truenas truenas deleted a comment from bugclerk Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonicaj sonicaj sonicaj approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE jira-low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yocalebo @bugclerk @sonicaj