NAS-125883 / 24.04 / Account for pss_skipped in scan progress
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
time 1:00 |
bugclerk
changed the title
pss_skipped in scan progresspss_skipped in scan progress
yocalebo
requested changes
Jan 4, 2024
themylogin
added a commit
to truenas/zfs
that referenced
this pull request
Jan 4, 2024
I need this to build truenas/py-libzfs#251
13 tasks
themylogin
force-pushed
the
NAS-125883
branch
2 times, most recently
from
9044011 to
6780df8
Compare
themylogin
force-pushed
the
NAS-125883
branch
from
6780df8 to
0b2ab05
Compare
|
time 1:00 |
amotin
reviewed
Jan 12, 2024
libzfs.pyx
Outdated
| @@ -2644,7 +2649,7 @@ cdef class ZPoolScrub(object): | |||
| if not self.bytes_to_scan: | |||
| return 0 | |||
|
|
|||
| return (<float>self.bytes_issued / <float>self.bytes_to_scan) * 100 | |||
| return (<float>self.bytes_issued / (<float>self.bytes_to_scan - <float>self.bytes_skipped)) * 100 | |||
There was a problem hiding this comment.
In zpool I also check for bytes_to_scan > bytes_skipped to avoid division by zero, but it should probably be extremely rare, if ever happen.
amotin
reviewed
Jan 17, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.