Prometheus #51
Merged
Prometheus #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented prometheus - Implemented prometheus Signed-off-by: naveensrinivasan <[email protected]> * Fixed codereview issues Signed-off-by: naveensrinivasan <[email protected]> * Included changes for code review. Signed-off-by: naveensrinivasan <[email protected]> * Fixed code review comments Signed-off-by: naveensrinivasan <[email protected]> * Updates based on code review Signed-off-by: naveensrinivasan <[email protected]> * Included changes for de-registering Signed-off-by: naveensrinivasan <[email protected]> * replaced the deregister with a nil Signed-off-by: naveensrinivasan <[email protected]> * Fixed code review comments. Signed-off-by: naveensrinivasan <[email protected]> * Fixed failing test condition. Signed-off-by: naveensrinivasan <[email protected]> * Removed the unused file. Signed-off-by: naveensrinivasan <[email protected]> * Included comments. Signed-off-by: naveensrinivasan <[email protected]> --------- Signed-off-by: naveensrinivasan <[email protected]>
- Included prometheus for guacql - Will include in all other guacsec#1500 (comment) if this is acceptable. Signed-off-by: naveensrinivasan <[email protected]>
Signed-off-by: naveensrinivasan <[email protected]>
Signed-off-by: m-brophy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt of merging prometheus logic based on #50, but tried to exclude schema and ent changes