Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CycloneDx: add HasMetadata to 'toplevel' package #54

Merged
merged 1 commit into from
Feb 20, 2024
Merged

CycloneDx: add HasMetadata to 'toplevel' package #54

merged 1 commit into from
Feb 20, 2024

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Feb 19, 2024

Description of the PR

Completes #53

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

mrizzi
mrizzi commented Feb 20, 2024
View reviewed changes
Copy link
Collaborator Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are fine so it introduces no regressions.
Going to merge it now.

@mrizzi mrizzi merged commit c79d40c into trustification:trustification-main Feb 20, 2024
1 check passed
@mrizzi mrizzi deleted the cyclonedx-hasMetadata-toplevelPkg branch February 20, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrizzi