-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gherkin scenarios for Search page #15
base: main
Are you sure you want to change the base?
Conversation
tests/features/search.feature
Outdated
|
||
Background: | ||
Given User is using an instance of the TPA Application | ||
When User has successfully uploaded an SBOM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho Background
should contain only Given
steps - as in shared setUpClass call performed before each Scenario
(or Outline instance), not When steps
at least per the docs - https://cucumber.io/docs/gherkin/reference/#background
although looking at code of playwright-bdd it seems it could handle here any type of step actually (not tested)
Given - actions to be performed as pre-test-setup
When - action to be performed as test (the actually tested action)
Then - assertion after/of the executed 'When' action(s)
Background section is meant for pre-setup initialization shared across multiple Scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added example - as Your first keyword is Given
then it can be changed to followup given
s by using And
.
Co-authored-by: Queria Sa-Tas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matejnesuta I have added few suggestions, Please review and let me know.
On the coverage, I hope header validation on each tab should be included.
Co-authored-by: Rajan Ravi <[email protected]>
Co-authored-by: Rajan Ravi <[email protected]>
Co-authored-by: Rajan Ravi <[email protected]>
No description provided.