Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gherkin scenarios for Search page #15

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

matejnesuta
Copy link
Collaborator

No description provided.


Background:
Given User is using an instance of the TPA Application
When User has successfully uploaded an SBOM
Copy link
Contributor

@queria queria Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho Background should contain only Given steps - as in shared setUpClass call performed before each Scenario (or Outline instance), not When steps

at least per the docs - https://cucumber.io/docs/gherkin/reference/#background
although looking at code of playwright-bdd it seems it could handle here any type of step actually (not tested)

Given - actions to be performed as pre-test-setup
When - action to be performed as test (the actually tested action)
Then - assertion after/of the executed 'When' action(s)

Background section is meant for pre-setup initialization shared across multiple Scenarios

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added example - as Your first keyword is Given then it can be changed to followup givens by using And.

@matejnesuta matejnesuta requested a review from queria January 21, 2025 11:40
Copy link
Contributor

@mrrajan mrrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matejnesuta I have added few suggestions, Please review and let me know.

On the coverage, I hope header validation on each tab should be included.

tests/features/search.feature Show resolved Hide resolved
tests/features/search.feature Outdated Show resolved Hide resolved
tests/features/search.feature Show resolved Hide resolved
tests/features/search.feature Outdated Show resolved Hide resolved
@matejnesuta matejnesuta requested a review from mrrajan January 27, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants