fix: Search Page does not search on the backend while typing #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Search Page does not search against the whole DB/Backend.
main branch:
useAllEntities
fetches entities based on afilterText
whose value is always empty""
filterEntityListByValue
which is trimming the results of the backend.After this PR:
useAllEntities
fetches continuously entities based on what the user types in the Input TextfilterEntityListByValue
has been removed and now we render "all" elements returned by the backend. The backend is better filtering data based on an input string so we do not need to cut/trim the original results.title
and thendescription
as a second alternative.ids
for entities to avoid collision (while running it I randomly saw that my browser told me multiple elements had the same id, not anymore with this change)