Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t benchmark on every PR. #1222

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

chirino
Copy link
Contributor

@chirino chirino commented Jan 31, 2025

This seems to fail PR ci checks consistently.

@helio-frota helio-frota self-requested a review January 31, 2025 14:15
@chirino chirino added this pull request to the merge queue Jan 31, 2025
@ctron
Copy link
Contributor

ctron commented Jan 31, 2025

maybe it makes sense to fix this instead?

Merged via the queue into trustification:main with commit 22250f3 Jan 31, 2025
3 checks passed
@chirino chirino deleted the drop-pr-benchmark branch January 31, 2025 14:42
@jcrossley3
Copy link
Contributor

maybe it makes sense to fix this instead?

maybe, but if it takes longer than a few minutes to run, I don't want it on every PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants