-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(work in progress) Initial start of a v2.x OAS/Swagger. #60
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darrellodonnell this looks very similar to v1 specs ( which is fine ). Would that be mostly the current intent of this proposal, to port over v1 first and work with that as a starting point?
nit: Change the PR to Draft status ( it's a button on the "conversations" ) tab, to indicate you are not ready for full review.
The intent of this work is manifold. Two of the inputs are:
Swagger is helpful here (and I'll be using a Swagger (OAS) to PlantUML tooling for some early UML models that can be refined as logical models. not: I changed the PR to draft. What does that mean? I want this code pushed in for sharing in the community ASAP. |
@darrellodonnell we can talk about the PR, but normally merging the PR into master means that it's accepted as the right thing to do, which requires review. Since I wasn't sure if you were planning to iterate on this before review, I suggested moving it to draft status until it was ready to be merged in. If you think it's ready to merge, then you can click "ready for review" (above) and we can discuss in more detail during the next TRTF call |
I am on PTO most of this week (other than today) and not likely to get the
work done that I had hoped (mostly the creation of the diagrams and a .md
file with an explainer). Let me see what I can do tonight.
…On Mon, Jan 23, 2023 at 10:51 AM Andor Kesselman ***@***.***> wrote:
@darrellodonnell <https://github.com/darrellodonnell> we can talk about
the PR, but normally merging the PR into master means that it's accepted as
the right thing to do, which requires review.
Since I wasn't sure if you were planning to iterate on this before review,
I suggested moving it to draft status until it was ready to be merged in.
If you think it's ready to merge, then you can click "ready for review"
(above) and we can discuss in more detail during the next TRTF call
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFHWB3BULX7WZYHYZG37Z3WT3HKFANCNFSM6AAAAAAT4GEUYM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Making this a little more accessible for those that don't understand how to read swagger docs: Copy this file here in the editor. graph TD
subgraph Query
direction LR
Issuer
Verifier
TrustRegistry[Trust Registry]
getofflinefile[Offline File]
end
subgraph Lookup
direction LR
DIDMethods[DID Methods]
presentationrequests[Presentation Requests]
credentialTypes[Credential Types]
overlays[Overlays]
resources[Resources]
end
|
initial v2 OAS/Swagger (work in progress)