Fix SPM: point root Package.swift binaryTargets to 4.7.3 release - #4847
Open
LeeeeSuHyeon wants to merge 1 commit into
Open
Fix SPM: point root Package.swift binaryTargets to 4.7.3 release#4847LeeeeSuHyeon wants to merge 1 commit into
LeeeeSuHyeon wants to merge 1 commit into
Conversation
Signed-off-by: 이수현 <leesuhyun@uniwaffle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The committed root
Package.swifthas been stale for ~1 year and still pins itsbinaryTargetURLs/checksums to the 4.2.9 release. Because SPM reads the manifest committed in the checked-out tree (not thePackage.swiftpublished as a release asset), every SPM consumer links the 4.2.9 binary regardless of the resolved version — so APIs added after 4.2.9 (e.g.TronSigningInput.rawJson,RippleSigningInput.rawJson) are missing at compile time even thoughPackage.resolvedshows a newer version.This PR updates the committed root
Package.swiftto the 4.7.3 artifacts, matching the correctPackage.swiftalready shipped as the 4.7.3 release asset:WalletCore→releases/download/4.7.3/WalletCore.xcframework.zip(checksum179b1276…)WalletCoreSwiftProtobuf→releases/download/4.7.3/WalletCoreSwiftProtobuf.xcframework.zip(checksum875e4d9f…)This also fixes the outdated Protobuf artifact name (
SwiftProtobuf.xcframework.zip→WalletCoreSwiftProtobuf.xcframework.zip).Fixes #4846
How to test
Point an SPM project at this branch:
Resolve packages, then confirm a post-4.2.9 API now compiles:
(These fail to compile against the current
master, which links 4.2.9.)Optionally verify the checksums match the published 4.7.3 assets:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
If you're adding a new blockchain