fix: Add PR number

trustyai-explainability · Feb 24, 2025 · 55e6b5f · 55e6b5f
1 parent 698f808
commit 55e6b5f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/smoke.yaml b/.github/workflows/smoke.yaml
@@ -8,6 +8,8 @@ on:
 jobs:
   deploy:
     runs-on: ubuntu-latest
+    env:
+      PR_NUMBER: ${{ github.event.pull_request.number || 'default-pr-number' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v2

diff --git a/tests/smoke/test_smoke.sh b/tests/smoke/test_smoke.sh
@@ -12,8 +12,7 @@ SERVICE_NAME_1="trustyai-service"
 SERVICE_NAME_2="trustyai-service-tls"
 DEPLOYMENT_NAME="trustyai-service-operator"
 
-EXPECTED_IMAGE="smoke/operator:pr-${{ github.event.pull_request.number || env.PR_NUMBER }}"
-
+EXPECTED_IMAGE="smoke/operator:pr-${PR_NUMBER:-default-pr-number}"
 
 log_success() {
     local message=$1
@@ -41,8 +40,8 @@ check_resource() {
 
 gen_cert() {
     openssl req -x509 -nodes -newkey rsa:2048 -keyout tls.key -days 365 -out tls.crt -subj '/CN=trustyai-service-tls'
-    oc create secret generic trustyai-service-internal  --from-file=./tls.crt --from-file=./tls.key -n "$NAMESPACE"
-    oc create secret generic trustyai-service-tls  --from-file=./tls.crt --from-file=./tls.key -n "$NAMESPACE"
+    kubectl create secret generic trustyai-service-internal  --from-file=./tls.crt --from-file=./tls.key -n "$NAMESPACE"
+    kubectl create secret generic trustyai-service-tls  --from-file=./tls.crt --from-file=./tls.key -n "$NAMESPACE"
     rm tls.key tls.crt
 }