Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LMES): Switch LMES driver to a container port #409

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

yhwang
Copy link
Collaborator

@yhwang yhwang commented Feb 12, 2025

Originally, the LMES driver used a Unix domain socket to serve the APIs which are used by the LMES controller to retrieve the job status. Switch to a container port to allow other containers in the same job pod to access the APIs as well.

@yhwang yhwang requested a review from ruivieira February 12, 2025 00:09
Originally, the LMES driver used a Unix domain socket to serve
the APIs which are used by the LMES controller to retrieve
the job status. Switch to a container port to allow other
containers in the same job pod to access the APIs as well.

Signed-off-by: Yihong Wang <[email protected]>
@ruivieira ruivieira added kind/enhancement New feature or request lm-eval Issues related to LM-Eval ok-to-test labels Feb 12, 2025
@ruivieira ruivieira added this to the ODH 2.25 milestone Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:e71394e0bd65e901202705827c219f155f479308

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:e71394e0bd65e901202705827c219f155f479308

📦 LMES job image: quay.io/trustyai/ta-lmes-job:e71394e0bd65e901202705827c219f155f479308

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-e71394e0bd65e901202705827c219f155f479308

Copy link

openshift-ci bot commented Feb 12, 2025

@yhwang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e71394e link true /test images
ci/prow/trustyai-service-operator-e2e e71394e link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yhwang

Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruivieira

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit 8fb6117 into trustyai-explainability:main Feb 12, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request lgtm lm-eval Issues related to LM-Eval ok-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants