Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay popping up for half a second at startup #77

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Fix overlay popping up for half a second at startup #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70fa3bc
Console logs for debugging trace of overlay startup
Fryingpannn Oct 25, 2024
4018680
Revert "Console logs for debugging trace of overlay startup"
Fryingpannn Oct 25, 2024
2e27727
Fix overlay appearing for half a second on startup
Fryingpannn Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ product.overrides.json
.vscode-test
extensions/pearai-submodule
extensions/pearai-ref
.prompts
7 changes: 5 additions & 2 deletions src/vs/workbench/browser/parts/overlay/pearOverlayPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,11 @@ export class PearOverlayPart extends Part {

// if both content and webview are ready, end loading state and open
if (this.popupAreaOverlay && this.webviewView) {
this.webviewView?.webview.layoutWebviewOverElement(this.popupAreaOverlay);
this.open();
//this.webviewView?.webview.layoutWebviewOverElement(this.popupAreaOverlay);
// createContentArea is called within the workbench and layout when instantiating the overlay.
// If we don't close it here, it will open up by default when editor starts, or appear for half a second.
// If we remove this completely, it gets stuck in the loading stage, so we must close it.
this.close();
} else {
// hide stuff while we load
this.fullScreenOverlay!.style.display = "none";
Expand Down
Loading