Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aider robustness 2 #193

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Aider robustness 2 #193

merged 2 commits into from
Nov 25, 2024

Conversation

nang-dev
Copy link

@nang-dev nang-dev commented Nov 25, 2024

Description ✏️

Closes #xxx

What changed? Feel free to be brief.

  • Bullet points are helpful.
  • Screenshots are helpful (if applicable).

Checklist ✅

  • I have added screenshots (if UI changes are present).
  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).

Important

Enhance Aider integration robustness by refining process state management and updating GUI to handle new states.

  • Behavior:
    • Refactor Aider model handling to use a single instance in core.ts and aiderUtil.ts.
    • Update AiderProcessManager in aiderProcess.ts to handle "restarting" state and block state change from "restarting" to "crashed".
    • Modify AiderGUI in aidergui.tsx to handle new "restarting" state and update UI messages accordingly.
  • State Management:
    • Add "restarting" state to AiderState in aiderTypes.ts.
    • Update state transitions in AiderProcessManager to handle process errors and restarts.
  • Misc:
    • Bump version in package.json from 1.5.2 to 1.5.3.
    • Remove redundant code and comments in AiderLLM.ts and aiderProcess.ts.

This description was created by Ellipsis for 3b0cbc9. It will automatically update as commits are pushed.

@nang-dev nang-dev requested review from Fryingpannn and a team as code owners November 25, 2024 23:03
@nang-dev nang-dev merged commit 2ce48c4 into main Nov 25, 2024
2 checks passed
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3b0cbc9 in 34 seconds

More details
  • Looked at 217 lines of code in 7 files
  • Skipped 1 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. core/llm/llms/AiderLLM.ts:198
  • Draft comment:
    Consider using this.getAiderProcess() instead of directly accessing Aider.aiderProcess to ensure the process is initialized.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses Aider.aiderProcess directly in multiple places, which can lead to issues if the process is not initialized. It's better to use the getAiderProcess() method to ensure the process is properly initialized before use.
2. core/llm/llms/AiderLLM.ts:215
  • Draft comment:
    Consider using this.getAiderProcess() instead of directly accessing Aider.aiderProcess to ensure the process is initialized.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses Aider.aiderProcess directly in multiple places, which can lead to issues if the process is not initialized. It's better to use the getAiderProcess() method to ensure the process is properly initialized before use.
3. extensions/vscode/src/integrations/aider/aiderUtil.ts:121
  • Draft comment:
    Consider using model.getAiderProcess() instead of directly accessing Aider.aiderProcess to ensure the process is initialized.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses Aider.aiderProcess directly in multiple places, which can lead to issues if the process is not initialized. It's better to use the getAiderProcess() method to ensure the process is properly initialized before use.

Workflow ID: wflow_qs0Al5H25waLMZpd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

nang-dev added a commit that referenced this pull request Feb 4, 2025
* Fixed build

* Added working

---------

Co-authored-by: nang-dev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant